Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and use json_formatter in Visual Studio #39630

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

ralreegorganon
Copy link
Contributor

Summary

Summary: NONE

Purpose of change

The project's custom JSON formatter wasn't trivially available to developers who were using the Visual Studio solution to build the project. Now it is.

Describe the solution

  • Added a project that builds the JSON formatter
  • Added a powershell script that runs the formatter over all of the json files in the data directory except those in the blacklist (this mirrors the behavior of the Makefile)
  • Added instructions for configuring the command to be invoked within Visual Studio via a menu and/or a shortcut key

Testing

Built the json formatter via the Visual Studio solution and configured it and ran it via the instructions I added. Confirmed that it considered all existing JSON to be well formed, and that it formatted new json. Confirmed that it still built and ran as expected in my macOS environment.

@ralreegorganon ralreegorganon added <Documentation> Design documents, internal info, guides and help. OS: Windows Issues related to Windows operating system [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Apr 17, 2020
@ZhilkinSerg ZhilkinSerg merged commit b75cf3f into CleverRaven:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs OS: Windows Issues related to Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants