Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split some traits from professions #40075

Merged
merged 2 commits into from
May 3, 2020

Conversation

Rail-Runner
Copy link
Contributor

Summary

SUMMARY: Balance "Split some traits from professions"

Purpose of change

Allow player to start with Helicopter Pilot and Skater traits, so that they're not locked to certain professions if they want them. I suppose "former pilot" and "hobby skater" could be valid things. Trait descriptions were edited to be a bit more generic while clarifying actual trait effects.

Also made Wayfarer and Helicopter Pilot traits mutually exclusive, since having Wayfarer won't let player control a helicopter even if they have Helicopter Pilot trait.

Describe the solution

JSON editing of trait entries.

Describe alternatives you've considered

Doing the same for some other profession traits, but most of them seem to assume that it's not just skills, but also being in certain databases, which wouldn't make sense for anyone but an active worker to have; also they're simply way too niche.

Testing

Made sure that both traits are available at character creation.
Made sure that Helicopter Pilot profession correctly starts with the trait.
Made sure that both of Helicopter Pilot profession and Helicopter Pilot trait allow controlling a helicopter.

Additional context

None.

@kevingranade
Copy link
Member

So your character is whatever else it's configured to be and just randomly also a helicopter pilot? That stretches credulity way too far which is why this was not available as a trait other than with a profession in the first place.

@Night-Pryanik
Copy link
Contributor

Well, some combinations like "senior citizen" profession and "former helicopter pilot" trait are viable.

@Rail-Runner
Copy link
Contributor Author

Rail-Runner commented May 3, 2020

So your character is whatever else it's configured to be and just randomly also a helicopter pilot?

I was thinking they're most likely either a former pilot, with enough knowledge remaining so that they can figure out how to operate one now (likely with their license having been revoked due to some violations, but who cares about that now), or someone who was about to become a pilot and just finished (or nearly finished) their training.

I can remove it and leave only changes related to Skater trait if it's still a problem, though.

@kevingranade
Copy link
Member

Feel free to add, "former pilot" or "student pilot" professions then, but those use cases don't justify throwing it open to combining the pilot trait with arbitrary professions.

I can remove it and leave only changes related to Skater trait if it's still a problem, though.

Please do.

@Rail-Runner
Copy link
Contributor Author

Rail-Runner commented May 3, 2020

Done.

I decided to keep the description change (since the old one gets outdated in case player manages to actually fly a helicopter) and Wayfarer-related change (so that pilots can't take Wayfarer trait since it kinda ruins the point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants