Split some traits from professions #40075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Split some traits from professions"
Purpose of change
Allow player to start with Helicopter Pilot and Skater traits, so that they're not locked to certain professions if they want them. I suppose "former pilot" and "hobby skater" could be valid things. Trait descriptions were edited to be a bit more generic while clarifying actual trait effects.
Also made Wayfarer and Helicopter Pilot traits mutually exclusive, since having Wayfarer won't let player control a helicopter even if they have Helicopter Pilot trait.
Describe the solution
JSON editing of trait entries.
Describe alternatives you've considered
Doing the same for some other profession traits, but most of them seem to assume that it's not just skills, but also being in certain databases, which wouldn't make sense for anyone but an active worker to have; also they're simply way too niche.
Testing
Made sure that both traits are available at character creation.
Made sure that Helicopter Pilot profession correctly starts with the trait.
Made sure that both of Helicopter Pilot profession and Helicopter Pilot trait allow controlling a helicopter.
Additional context
None.