Sanitize URL, Debug Statements, License Mappings 2025-07-22 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
juliojimenez
added
enhancement
github_actions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces URL sanitization functionality, converts some debug logging statements, and fixes a license mapping. The changes improve input validation security and adjust logging verbosity for better debugging.
- Adds a comprehensive
sanitize_urlfunction with type-specific validation for different services - Enables URL sanitization for Mend, Wiz, and ClickHouse endpoints by uncommenting existing code
- Changes informational log statements to debug level for less verbose output
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/sanitize.sh | Adds new sanitize_url function and enables URL sanitization for various endpoints |
| test/simple.bats | Adds comprehensive test coverage for the new sanitize_url function |
| entrypoint.sh | Changes log level from info to debug for sample content output |
| license-mappings.json | Fixes package name from "eslint-plugin-expect-types" to "eslint-plugin-expect-type" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
juliojimenez
deleted the
sanitize-url-debug-statements-licenses-2025-07-22
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.