-
Notifications
You must be signed in to change notification settings - Fork 1
Sanitize UUID, Debug Sections, Licenses 2025-07-24 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize UUID, Debug Sections, Licenses 2025-07-24 #19
Conversation
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements UUID sanitization functionality and updates license mappings. The changes enable proper validation and sanitization of UUID parameters for Mend security tool integration while adding new dependencies to the license tracking system.
- Added
sanitize_uuidfunction with comprehensive validation for hexadecimal UUID formats - Uncommented and activated UUID sanitization for all Mend-related environment variables
- Updated license mappings for two new Go dependencies
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/sanitize.sh |
Implements UUID sanitization function and enables UUID validation for Mend environment variables |
test/simple.bats |
Adds comprehensive test coverage for UUID sanitization scenarios |
license-mappings.json |
Adds license information for ClickHouse and fatcontext dependencies |
Comments suppressed due to low confidence (3)
test/simple.bats:613
- The test name 'rejects non-hex characters' doesn't match the test behavior. The test shows that non-hex characters are removed, not rejected. Consider renaming to 'sanitize_uuid removes non-hex characters' to match the actual behavior.
@test "sanitize_uuid rejects non-hex characters" {
test/simple.bats:612
- The comment indicates this test is for 'too long UUID' but the actual test is for non-hex characters. The comment should be updated to match the test content.
# Test 65: sanitize_uuid rejects too long UUID
test/simple.bats:616
- This test is missing coverage for the case where a UUID is actually too long. The current tests cover too short (Test 64) and non-hex characters (Test 65), but there's no test for a UUID that exceeds the maximum expected length.
[[ "$output" == "1234567-e89b-12d3-a456-426614174000" ]]
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
No description provided.