Sanitize Database Name, Licenses 2025-07-28 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds license mappings for 22 new Go packages and implements sanitization for ClickHouse database names.
- Adds license mappings for packages from various organizations including Baidu, ByteDance, and GitHub maintainers
- Implements a new
sanitize_database_name()function with alphanumeric and underscore validation - Enables previously commented-out ClickHouse database name sanitization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| license-mappings.json | Adds license mappings for 22 new Go packages with various licenses (MIT, Apache-2.0, BSD-3-Clause) |
| lib/sanitize.sh | Implements database name sanitization function and enables ClickHouse database name validation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Signed-off-by: Julio Jimenez <julio@clickhouse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.