Skip queries that fail on every filtered system#876
Merged
Conversation
When all selected systems return null for a query, the per-query baseline becomes Math.min() over an empty set (Infinity), which makes log(curr/Infinity) = -Infinity and collapses every system's geometric mean to 0 - bars render with width 0 and the chart appears empty. Reproduction: filter to Elasticsearch + Quickwit (Q28's REGEXP_REPLACE fails on both). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Math.min()over an empty set (Infinity), solog(curr / Infinity) = -Infinitycollapses every system's geometric mean to 0. All bars then render with width 0 and the chart appears empty.relativeQueryTime, skip queries whose baseline is non-finite, and returnnullif no queries remain.Reproduction
Filter on the dashboard to Elasticsearch + Quickwit (e.g. this URL) — Q28 (
REGEXP_REPLACE) fails on both, and the bar chart vanishes. With the fix, Q28 is skipped from the geometric mean and bars render normally.Test plan
🤖 Generated with Claude Code