Fix: Enum8 and AggregateFunction dropped#25
Merged
alex-clickhouse merged 3 commits intoMay 26, 2026
Merged
Conversation
Felixzed
force-pushed
the
feat/enum8-aggregatefunction-support
branch
from
e28cb7b to
af1c214
Compare
Collaborator
|
Hi, thanks for the PR! Ok, I think the right thing to do is to change the failing tests actually. The behavior is correct. Also, please add a note in CHANGELOG and RELEASENOTES. We should also have some more comprehensive testing to catch this sort of thing earlier, will add that in another PR. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
alex-clickhouse
approved these changes
May 26, 2026
Collaborator
|
Thank you for the contribution! |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #24
This was made with the help of an LLM
Previously, it seems like type mapping of Enum8 and AggregateFunction got stuck on some code that unwrapped LowCardinality() and Nullable() and defaulted to a String type.