Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adds first-class support for ClickHouse’s Json column type in the EFCore.ClickHouse provider, including a new relational type mapping and accompanying docs/tests.
Changes:
- Introduces
ClickHouseJsonTypeMappingto map ClickHouseJsontoJsonNode(and optionallystringon read). - Registers
JsoninClickHouseTypeMappingSource, including handling forJson(...)type-hint syntax. - Adds integration/unit tests and updates README to document JSON usage and limitations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/EFCore.ClickHouse.Tests/JsonTypeMappingTests.cs | New integration + unit tests for JSON read/write and mapping behaviors |
| src/EFCore.ClickHouse/Storage/Internal/Mapping/ClickHouseJsonTypeMapping.cs | New RelationalTypeMapping implementation for ClickHouse Json |
| src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs | Wires JSON mapping into CLR/store-type resolution and parsing |
| README.md | Documents JSON support, examples, and limitations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.