Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Adds ClickHouse geo (geographic) store-type support to the EFCore.ClickHouse provider by wiring geo aliases to existing structural Tuple/Array/Variant mappings, plus adding a dedicated integration/unit test suite and documenting the new capability.
Changes:
- Add geo store type mappings (
Point,Ring,LineString,Polygon,MultiLineString,MultiPolygon,Geometry) toClickHouseTypeMappingSource. - Add unit + integration tests covering geo type mapping resolution, SQL literal generation, and basic round-trips.
- Update README to document geo support and remove “Geo types” from the unsupported list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/EFCore.ClickHouse.Tests/GeoTypeMappingTests.cs | New unit/integration tests for geo type mappings and round-trip behavior. |
| src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs | Registers geo store types as structural aliases using existing Tuple/Array/Variant mappings. |
| README.md | Documents geo support and updates the “unsupported” section accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.