Skip to content

Fix MarkCacheHits/MarkCacheMisses for save_marks_in_cache=false#83415

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:fix-marks-cache-metrics
Jul 9, 2025
Merged

Fix MarkCacheHits/MarkCacheMisses for save_marks_in_cache=false#83415
azat merged 1 commit intoClickHouse:masterfrom
azat:fix-marks-cache-metrics

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 7, 2025

save_marks_in_cache=false uses get which is not overwritten:

if (save_marks_in_cache)
{
auto callback = [this] { return loadMarksImpl(); };
loaded_marks = mark_cache->getOrSet(key, callback);
}
else
{
loaded_marks = mark_cache->get(key);
if (!loaded_marks)
loaded_marks = loadMarksImpl();
}

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 7, 2025

Workflow [PR], commit [8ce56d8]

Summary:

job_name test_name status info comment
Build (fuzzers) error

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 7, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 9, 2025

PR / Build (fuzzers) (pull_request)
PR / Build (fuzzers) (pull_request)Failing after 33m

@azat azat enabled auto-merge July 9, 2025 08:56
@azat azat added this pull request to the merge queue Jul 9, 2025
Merged via the queue into ClickHouse:master with commit d69c954 Jul 9, 2025
119 of 121 checks passed
@azat azat deleted the fix-marks-cache-metrics branch July 9, 2025 09:11
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants