-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add ALTER TABLE REWRITE PARTS #87774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Workflow [PR], commit [95a9cd0] Summary: ❌
|
309137a to
8bb4c1a
Compare
This makes it confusing. For MATERIALIZE INDEX, MATERIALIZE PROJECTION, and similar things, it does the calculation and persists the data if it didn't exist. But from the description above, you made MATERIALIZE rewrite the table unconditionally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
|
Yes, but this is only for Maybe the naming is not good, would appreciate any ideas |
|
Maybe Or |
|
Yes, the word should be different. It should contain the word "parts" to emphasize that the parts remain the same (not being merged) and have some other word than "materialize" (to emphasize that it rewrites parts even if everything is already persisted). The feature is useful not only for changing index granularity or compress block size, but also - for rotating encryption keys. |
|
Let it be |
8bb4c1a to
26ed327
Compare
|
Done |
|
26ed327 to
2308066
Compare
This can be useful to apply some settings (i.e. enable `use_const_adaptive_granularity` once you realized that the size of granulas array became to big for all parts) that requires rewriting all parts.
2308066 to
67cfed6
Compare
|
|
@alexey-milovidov PTAL |
|
CI:
|
5ccb2f5
|
@alexey-milovidov FYI I've added more tests here - #89382 |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Add
ALTER TABLE REWRITE PARTS- rewrites the table parts from scratch, by using all new settings (since some, likeuse_const_adaptive_granularity, will be applied only for new parts).