Introduce cpr/mvr operations for Keeper client
#88570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow [PR], commit [817ef6e] Summary: ⏳
|
antonio2368
reviewed
Oct 15, 2025
| } | ||
| }; | ||
|
|
||
| class CPRCommand : public IKeeperClientCommand |
There was a problem hiding this comment.
It's like we are giving CPR to Keeper 🩺
programs/keeper-client/Commands.cpp
Outdated
| /// Copy tree | ||
| for (const auto & [subpath, data, version] : subtree_nodes) | ||
| { | ||
| ops.push_back(zkutil::makeCheckRequest(src + subpath, version)); |
There was a problem hiding this comment.
you can exclude check if you have remove_src. To fail early, you can do removes first
programs/keeper-client/Commands.cpp
Outdated
| is_completed = true; | ||
| return; | ||
| } | ||
| case Coordination::Error::ZBADVERSION: { |
There was a problem hiding this comment.
if we want to make it even more robust, we could retry on ZNONODE and the missing node is not the root source node.
There was a problem hiding this comment.
Added a check for the first failed op path
antonio2368
reviewed
Oct 15, 2025
antonio2368
approved these changes
Oct 16, 2025
robot-ch-test-poll4
added
the
pr-synced-to-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Add recursive variants of
cp-cprandmv-mvrcommands in Keeper client.