remove try/catch from ~PooledConnection

[mstetsyuk]

Changelog category (leave one):

• Not for changelog (changelog entry is not required)

[clickhouse-gh]

Workflow [PR], commit [51eae77]

Summary: ✅

[Copilot]

Pull Request Overview

This PR removes the try-catch block from the ~PooledConnection() destructor, eliminating the exception handling that was previously suppressing and logging any exceptions thrown during connection cleanup.

Key Changes:

• Removed try-catch wrapper from the destructor body
• Eliminated the tryLogCurrentException call that was logging caught exceptions

[Copilot]

Removing the try-catch block from a destructor is risky because destructors are implicitly noexcept in C++11 and later. If any exception is thrown during the cleanup operations (e.g., from response_stream operations or metrics updates), the program will call std::terminate() and crash. Consider either keeping the try-catch to handle exceptions gracefully, or ensure all operations within the destructor are guaranteed not to throw.

[CheSema]

Adding try catch in every d-tors makes a noise.
You mute exception in d-tor not by choice but out of necessity, as a result you mute an undefined wide set of exceptions. Much better approach is to guarantee that all actions in d-tor are not able to throw.