-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix S3 client clone #89923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S3 client clone #89923
Conversation
|
Workflow [PR], commit [0dcb494] Summary: ❌
|
|
@antonio2368 Time to think how to write good tests for it: |
The issue is we are working around the specific behavior of GCS so I don't see a way to test it correctly unless we connect to it directly. Also, the source of all those issues is using AWS client for GCS interaction which we reverse engineer based on the responses we get (+ it changes constantly). Using native client would definitely help. |
|
@antonio2368 I was thinking about checking it from the C++ standpoint. For example to write a private However, this test won't fail in case if you add a new field to the class and don't update the |
|
CI experiences some instability. Not related to the PR, because we have no real tests on top of GCP. |
Cherry pick #89923 to 25.3: Fix S3 client clone
Cherry pick #89923 to 25.8: Fix S3 client clone
Cherry pick #89923 to 25.9: Fix S3 client clone
Cherry pick #89923 to 25.10: Fix S3 client clone
Backport #89923 to 25.8: Fix S3 client clone
Backport #89923 to 25.9: Fix S3 client clone
Backport #89923 to 25.10: Fix S3 client clone
Backport #89923 to 25.3: Fix S3 client clone

Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix using native copy on GCS for backups. Because of incorrect client cloning, GCS native copy always failed and used less optimal approach of manual reading and writing the data.
Documentation entry for user-facing changes