fix: improve sorting logic in renderSummary to handle NaN values#27
Closed
waynexia wants to merge 1 commit intoClickHouse:mainfrom
Closed
fix: improve sorting logic in renderSummary to handle NaN values#27waynexia wants to merge 1 commit intoClickHouse:mainfrom
waynexia wants to merge 1 commit intoClickHouse:mainfrom
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Author
Member
|
@waynexia Thanks for this PR, I think it can be merged. One question I had is why we show "NaN" at all for "Elasticsearch (no source, best compression)". I could not find "NaN" in the corresponding result .json file (and in fact I could not find "NaN" in any result .json file of any database). |
Contributor
|
it seems we missed |
Member
|
It is better to correct the single incorrect JSON document (out of >60 JSON documents), than to add special handling in JavaScript. In this particular case, field --> #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix render logic.
Some cases (like
Elasticsearch (no source, best compression)) will bring NaN values. They may break the sorting logic and generate weird illustrations.This patch enhances NaN handling in both comparison logic and relative scale rendering.