Skip to content

chore(publish.yml): remove upgrading npm step#1007

Merged
hoorayimhelping merged 1 commit intomainfrom
bucky-publish
Apr 21, 2026
Merged

chore(publish.yml): remove upgrading npm step#1007
hoorayimhelping merged 1 commit intomainfrom
bucky-publish

Conversation

@hoorayimhelping
Copy link
Copy Markdown
Member

We're trying to fix publishing to npm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: 5b6b7e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Claude finished @hoorayimhelping's task in 22s —— View job


Review: chore(publish.yml): remove upgrading npm step

  • Read changed files
  • Understand the change
  • Post review

✅ Looks great! No issues found — nice work!

The removed step (npm install -g npm@latest) is redundant now that the workflow pins Node 22, which ships with npm ≥ 11.5.1 and native OIDC support. Removing the explicit upgrade step simplifies the workflow and avoids the overhead of a redundant global install. The inline comment on the setup-node step documents exactly why the upgrade is no longer needed.

No must-fix issues, no a11y concerns (CI workflow), no test gaps. This is a clean, low-risk cleanup.


@hoorayimhelping hoorayimhelping merged commit dfe50b7 into main Apr 21, 2026
9 checks passed
@hoorayimhelping hoorayimhelping deleted the bucky-publish branch April 21, 2026 20:15
@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-nrw9d0qnt-clickhouse.vercel.app

Built from commit: 14557398cd1c207b4893b507f61842f2407e6a1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants