Skip to content

fix(publish.yml): revert OIDC support change#1010

Merged
DreaminDani merged 1 commit intomainfrom
dani-fix-oidc-support
Apr 21, 2026
Merged

fix(publish.yml): revert OIDC support change#1010
DreaminDani merged 1 commit intomainfrom
dani-fix-oidc-support

Conversation

@DreaminDani
Copy link
Copy Markdown
Contributor

revert

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: fa8188e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Claude finished @DreaminDani's task in 17s —— View job


Review: revert OIDC support change

  • Read diff and reviewed changes

✅ Looks great! No issues found — nice work!

The removed step (npm install -g npm@latest) is redundant: the preceding setup-node action already pins Node 22, whose bundled npm (≥ 11.5.1) includes OIDC support out of the box. The inline comment on that line (# Node 22 includes npm >= 11.5.1 with OIDC support) confirms this. Removing the explicit upgrade step is correct and keeps the workflow leaner.

No functional, security, or API concerns here. Safe to merge.

@DreaminDani DreaminDani changed the title revert OIDC support change fix(publish.yml): revert OIDC support change Apr 21, 2026
@DreaminDani DreaminDani merged commit 65fb146 into main Apr 21, 2026
9 of 10 checks passed
@DreaminDani DreaminDani deleted the dani-fix-oidc-support branch April 21, 2026 20:38
@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-conr4bvpj-clickhouse.vercel.app

Built from commit: c62d2174f8784880f01bc7e27d319e12f17fd64b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants