Skip to content

chore(publish.yml): update node version to 23#1011

Merged
hoorayimhelping merged 1 commit intomainfrom
bucky-publish-update-node-version
Apr 21, 2026
Merged

chore(publish.yml): update node version to 23#1011
hoorayimhelping merged 1 commit intomainfrom
bucky-publish-update-node-version

Conversation

@hoorayimhelping
Copy link
Copy Markdown
Member

iterating on publish.yml

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: c26f986

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hoorayimhelping hoorayimhelping force-pushed the bucky-publish-update-node-version branch from 61bb9ce to c26f986 Compare April 21, 2026 21:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Claude finished @hoorayimhelping's task in 29s —— View job


PR Review: chore(publish.yml): update node version to 23

  • Read changed files
  • Analyze the change

The change is small and targeted — just a Node version bump in the publish workflow. A couple of things worth flagging:

🚨 Must Fix

  • Node 23 is not an LTS release. Odd-numbered Node.js versions (17, 19, 21, 23) are "Current" releases that receive only 6 months of support and are explicitly not recommended for production use. For a publish workflow, a stable LTS version is strongly preferred. The current LTS options are:

    • Node 22 (Active LTS until Oct 2025, Maintenance until Apr 2026) — the version you just replaced
    • Node 24 (Active LTS starting Oct 2025) — the next LTS if an upgrade is needed

    Consider upgrading to 24.x instead if the goal is to get a newer Node/npm. Fix this →

💡 Suggestion

  • The inline comment still says # Node 22 includes npm >= 11.5.1 with OIDC support after changing to Node 23. Either update the comment to reference Node 23/24, or remove it since the original multi-line explanation was already cleaned up.

@hoorayimhelping hoorayimhelping merged commit d0e5639 into main Apr 21, 2026
7 checks passed
@hoorayimhelping hoorayimhelping deleted the bucky-publish-update-node-version branch April 21, 2026 21:05
@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-gig5kbftf-clickhouse.vercel.app

Built from commit: cae84bd00583471ec75a409613153ba184541a66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants