Table: align cell text vertically#555
Merged
natalyjazzviolin merged 1 commit intomainfrom Feb 26, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vineethasok
approved these changes
Feb 25, 2025
| display: inline-block; | ||
| white-space: nowrap; | ||
| text-overflow: ellipsis; | ||
| vertical-align: text-bottom; |
Member
There was a problem hiding this comment.
I think this will need to be set as a prop and passed in by Table, rather than hardcoded in. EllipsesContainer is used in a lot of places in click-ui and CP and this might change behavior in those places.
Collaborator
There was a problem hiding this comment.
I don't think we need to add it as a prop as we always want to be center aligned
@natalyjazzviolin Just a doubt in case we are removing the ellipsis as @hoorayimhelping mentioned then we might need to change this to middle instead of text-bottom
Maybe we can do it in another pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The table cell text is slightly off center vertically and has more room on the bottom.
What
This aligns it vertically by moving it a little down.
Closes #551