Make GridContainer a polymorphic, ref-forwarding component #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored GridContainer to support polymorphic 'component' prop and forward refs using React.forwardRef. This allows rendering as different HTML elements and improves flexibility for consumers.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GridContainer component to be polymorphic and support ref forwarding. The component can now render as different HTML elements through a component prop and properly forwards refs to the underlying DOM element.
Key changes:
- Added polymorphic support allowing the component to render as any HTML element
- Implemented ref forwarding using React.forwardRef
- Updated TypeScript types to support the new polymorphic behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ariser
reviewed
Aug 27, 2025
ariser
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored GridContainer to support polymorphic 'component' prop and forward refs using React.forwardRef. This allows rendering as different HTML elements and improves flexibility for consumers.