Skip to content

refactor: 💡 filename truncation adapt responsiveness#779

Closed
punkbit wants to merge 10 commits intomainfrom
refactor/filename-truncation-adapt-responsiveness
Closed

refactor: 💡 filename truncation adapt responsiveness#779
punkbit wants to merge 10 commits intomainfrom
refactor/filename-truncation-adapt-responsiveness

Conversation

@punkbit
Copy link
Copy Markdown
Contributor

@punkbit punkbit commented Jan 27, 2026

Why?

Adapts file upload filename truncation responsiveness, e.g. shows truncated file name on smaller container sizes, showing the original otherwise. It shows the complete filename on element hover.

⚠️ WARNING: Depends on #775, which should be merged first.
🤖 Must switch base branch once #775 merged

How?

  • Create a new wrapper component
  • Add styles for responsiveness
  • Use Aria tags to prevent screen readers from reading duplicate filename text
  • Show complete file name on hover (accessibility)

Preview?

demo-filename-reveal.mov

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 4003332

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
click-ui Ready Ready Preview, Comment Jan 28, 2026 9:36am

Request Review

Base automatically changed from chore/filename-shorten-middle to main January 27, 2026 14:17
Copy link
Copy Markdown
Collaborator

@crisalbu crisalbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name should not drop on a second line. .csv should be on the same, we just need to truncate it more.

Image

Copy link
Copy Markdown
Collaborator

@crisalbu crisalbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I was hoping this to work was to remove one letter at a time as the Viewport becomes more narrow.

I wouldn't remove that many at once.

@punkbit
Copy link
Copy Markdown
Contributor Author

punkbit commented Jan 28, 2026

The way I was hoping this to work was to remove one letter at a time as the Viewport becomes more narrow.

I wouldn't remove that many at once.

See this faked version instead #781

@punkbit punkbit closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants