chore: 🤖 remove leaked styling library types from public api#847
chore: 🤖 remove leaked styling library types from public api#847
Conversation
…-api-as-exports-generator-source-of-truth
…into chore/remove-leaked-styling-library-types-from-public-api
|
Claude finished @punkbit's task in 1m 14s —— View job PR ReviewClean approach — moving deprecated exports into a clearly labeled section with JSDoc and a migration guide is exactly right. The changes in Two items from the prior review are still unaddressed: 🚨 Must Fix
💡 Suggestions (non-blocking)
|
|
Claude finished @punkbit's task in 1m 2s —— View job PR ReviewBoth issues flagged in the previous review have been addressed — nice work! 🙌 The changeset (
The deprecated exports in
💡 Suggestions (non-blocking)
✅ The core goal of this PR is solid — deprecations are clean, backward-compatible, and well-documented. Ready to merge once the |
These are not consumed and shouldn't be exported in the first place. Ignore. |
|
Claude finished @punkbit's task in 43s —— View job PR ReviewAll previously flagged items have been addressed — great work! 🙌
The No remaining issues. This PR is ready to merge. ✅ |
|
Claude finished @punkbit's task in 33s —— View job PR Review✅ All previous issues have been addressed — this is clean and well-executed! The PR correctly:
💡 Suggestions (non-blocking)
✅ No blocking issues. Looks great — nice work! 🙌 |
📚 Storybook Preview Deployed✅ Preview URL: https://click-j8zjn42as-clickhouse.vercel.app Built from commit: |
Why?
Removed StyledLinkProps and linkStyles from the public API to prevent leaking styled-components implementation details, e.g., the $size and $weight transient props. The Link component already accepts a component prop to render as any element type, has size and weight props, and forwards all other props, e.g. onClick, etc.
🤖 On #845 merge, change base branch to main
How?
Preview?
N/A