chore(dialog): 🤖 add story for new description prop#974
Conversation
|
| Name | Type |
|---|---|
| @clickhouse/click-ui | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
Claude finished @punkbit's task in 1m 10s —— View job Code ReviewNice follow-up to #973! The changeset Before/After examples are a helpful addition for consumers, and the story is cleanly structured. ✅ No blocking issues found. 💡 Suggestions (non-blocking)
|
📚 Storybook Preview Deployed✅ Preview URL: https://click-mfhn0j8yd-clickhouse.vercel.app Built from commit: |
* fix(Dialog): use Radix DialogTitle primitive for accessibility * feat(Dialog): add description prop for Radix DialogDescription * chore: add changeset for Dialog accessibility fix * chore: format Dialog.tsx * fix(Dialog): style description with theme tokens * chore(dialog): 🤖 add story for new description prop (#974) * chore: 🤖 add with description story, showcasing description usage * chore: 🤖 add changeset --------- Co-authored-by: Helder Oliveira <helder.oliveira@clickhouse.com>
* fix(Dialog): use Radix DialogTitle primitive for accessibility * feat(Dialog): add description prop for Radix DialogDescription * chore: add changeset for Dialog accessibility fix * chore: format Dialog.tsx * fix(Dialog): style description with theme tokens * chore(dialog): 🤖 add story for new description prop (#974) * chore: 🤖 add with description story, showcasing description usage * chore: 🤖 add changeset --------- Co-authored-by: Helder Oliveira <helder.oliveira@clickhouse.com>
Why?
Following up on #973 by @dustinhealy, I’ve added some before/after examples to the changeset and set up a new Storybook story. Using the newly introduced description prop for shorter text looks cleaner and handles the accessibility semantics better.
How?
Preview?