Skip to content

chore(dialog): 🤖 add story for new description prop#974

Merged
punkbit merged 2 commits intofix/dialog-radix-titlefrom
chore/dialog-radix-title-add-story-for-description
Apr 9, 2026
Merged

chore(dialog): 🤖 add story for new description prop#974
punkbit merged 2 commits intofix/dialog-radix-titlefrom
chore/dialog-radix-title-add-story-for-description

Conversation

@punkbit
Copy link
Copy Markdown
Contributor

@punkbit punkbit commented Apr 9, 2026

Why?

Following up on #973 by @dustinhealy, I’ve added some before/after examples to the changeset and set up a new Storybook story. Using the newly introduced description prop for shorter text looks cleaner and handles the accessibility semantics better.

How?

  • Updates changeset
  • Create a new story "with description"

Preview?

Screenshot 2026-04-09 at 10 33 15

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: fc22621

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@punkbit punkbit requested a review from dustinhealy April 9, 2026 09:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Claude finished @punkbit's task in 1m 10s —— View job


Code Review

Nice follow-up to #973! The changeset Before/After examples are a helpful addition for consumers, and the story is cleanly structured.

No blocking issues found.


💡 Suggestions (non-blocking)

  • WithDescription story: The story uses <Dialog open> (a controlled prop) without onOpenChange, so pressing "Cancel" or the ✕ close button won't actually dismiss the dialog in Storybook — the dialog stays pinned open. This is a common pattern for static visual demos and is fine here, but the other stories use a stateful wrapper (DialogExample) to make them interactive. Worth noting for consistency if interactivity is ever desired.

  • Changeset Before/After: The "Before" example uses <Text color="muted"> as a child for description content, while the "After" uses the new description prop — this is a good illustration of the migration path. One small thing: the indentation inside the <Text> tag in the Before block is off (content starts on a new line with no indentation), but that's a cosmetic-only issue in docs.


✅ Looks great overall — the story accurately demonstrates the description prop with proper Radix aria-describedby semantics via RadixDialog.Description. Nice work! 🙌

@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-mfhn0j8yd-clickhouse.vercel.app

Built from commit: 40e845e7667f505732c1cff7b3a89be06c9ffc36

@punkbit punkbit merged commit 0036a0e into fix/dialog-radix-title Apr 9, 2026
9 of 10 checks passed
@punkbit punkbit deleted the chore/dialog-radix-title-add-story-for-description branch April 9, 2026 13:32
dustinhealy added a commit that referenced this pull request Apr 9, 2026
* fix(Dialog): use Radix DialogTitle primitive for accessibility

* feat(Dialog): add description prop for Radix DialogDescription

* chore: add changeset for Dialog accessibility fix

* chore: format Dialog.tsx

* fix(Dialog): style description with theme tokens

* chore(dialog): 🤖 add story for new description prop (#974)

* chore: 🤖 add with description story, showcasing description usage

* chore: 🤖 add changeset

---------

Co-authored-by: Helder Oliveira <helder.oliveira@clickhouse.com>
dustinhealy added a commit that referenced this pull request Apr 9, 2026
* fix(Dialog): use Radix DialogTitle primitive for accessibility

* feat(Dialog): add description prop for Radix DialogDescription

* chore: add changeset for Dialog accessibility fix

* chore: format Dialog.tsx

* fix(Dialog): style description with theme tokens

* chore(dialog): 🤖 add story for new description prop (#974)

* chore: 🤖 add with description story, showcasing description usage

* chore: 🤖 add changeset

---------

Co-authored-by: Helder Oliveira <helder.oliveira@clickhouse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants