Fixes #159 - quoting and escaping string literals inside lists#161
Merged
genzgd merged 1 commit intoClickHouse:mainfrom Apr 4, 2023
Merged
Fixes #159 - quoting and escaping string literals inside lists#161genzgd merged 1 commit intoClickHouse:mainfrom
genzgd merged 1 commit intoClickHouse:mainfrom
Conversation
|
|
genzgd
approved these changes
Apr 4, 2023
Collaborator
|
This is great, thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #159 - quoting and escaping string literals inside lists
Note
The PR could be completed with more tests (e.g. tuples, dicts, etc) and more scoped tests (e.g. unit testing
format_strandescape_strthemselves). Feel free to take over the PR and do it.Checklist
Delete items not relevant to your PR: