nit: change unexpected http error log to warning level#173
Merged
genzgd merged 3 commits intoClickHouse:mainfrom Apr 25, 2023
Merged
Conversation
genzgd
approved these changes
Apr 25, 2023
Collaborator
|
Yeah, exception seems like overkill :) |
Contributor
Author
|
Thank you @genzgd! |
Contributor
Author
|
LMK if this needs a bullet point in CHANGELOG. |
Collaborator
|
If you want to add it to the changelog that's fine, I'm planning on a small release probably next week. |
Contributor
Author
|
Done, but not sure about your policy. |
Signed-off-by: Alexandros <alexandrosandre@users.noreply.github.com>
Collaborator
|
I think your fork is out of date, 0.5.20 is already out. Do you mind moving it back up to the "WIP" like before? |
genzgd
approved these changes
Apr 25, 2023
Collaborator
|
Don't worry about it, I'll add the new changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this error scenario the library is logging an error and raising it at the same time. This contradicts the generally adopted behavior of logging debug messages only and raising error scenarios as exceptions to the caller. As a result, callers cannot decide on their own whether they want to handle the exception silently (e.g. with their own retries) or not, because their log will always include the ERROR log of the library.
Not sure whether we should delete the log, I went for the less aggressive change in case anyone created dependencies on it.
Checklist
Delete items not relevant to your PR: