Skip to content

nit: change unexpected http error log to warning level#173

Merged
genzgd merged 3 commits intoClickHouse:mainfrom
alexandrosandre:alexandrosandre-change-http-error-log-level
Apr 25, 2023
Merged

nit: change unexpected http error log to warning level#173
genzgd merged 3 commits intoClickHouse:mainfrom
alexandrosandre:alexandrosandre-change-http-error-log-level

Conversation

@alexandrosandre
Copy link
Copy Markdown
Contributor

@alexandrosandre alexandrosandre commented Apr 25, 2023

Summary

In this error scenario the library is logging an error and raising it at the same time. This contradicts the generally adopted behavior of logging debug messages only and raising error scenarios as exceptions to the caller. As a result, callers cannot decide on their own whether they want to handle the exception silently (e.g. with their own retries) or not, because their log will always include the ERROR log of the library.

Not sure whether we should delete the log, I went for the less aggressive change in case anyone created dependencies on it.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 25, 2023

CLA assistant check
All committers have signed the CLA.

@genzgd
Copy link
Copy Markdown
Collaborator

genzgd commented Apr 25, 2023

Yeah, exception seems like overkill :)

@alexandrosandre alexandrosandre marked this pull request as ready for review April 25, 2023 15:19
@alexandrosandre
Copy link
Copy Markdown
Contributor Author

Thank you @genzgd!

@alexandrosandre
Copy link
Copy Markdown
Contributor Author

LMK if this needs a bullet point in CHANGELOG.

@genzgd
Copy link
Copy Markdown
Collaborator

genzgd commented Apr 25, 2023

If you want to add it to the changelog that's fine, I'm planning on a small release probably next week.

@alexandrosandre
Copy link
Copy Markdown
Contributor Author

Done, but not sure about your policy.

Signed-off-by: Alexandros <alexandrosandre@users.noreply.github.com>
@genzgd
Copy link
Copy Markdown
Collaborator

genzgd commented Apr 25, 2023

I think your fork is out of date, 0.5.20 is already out. Do you mind moving it back up to the "WIP" like before?

@genzgd genzgd merged commit 2d45a23 into ClickHouse:main Apr 25, 2023
@genzgd
Copy link
Copy Markdown
Collaborator

genzgd commented Apr 25, 2023

Don't worry about it, I'll add the new changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants