Fix shared variant decoding for JSON and Dynamic columns#677
Merged
joe-clickhouse merged 4 commits intomainfrom Mar 10, 2026
Merged
Fix shared variant decoding for JSON and Dynamic columns#677joe-clickhouse merged 4 commits intomainfrom
joe-clickhouse merged 4 commits intomainfrom
Conversation
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONandDynamicvalues when data is stored in shared overflow structures rather than ordinary typed subcolumns. This affectedJSONpath overflow cases,Dynamicshared-variant cases, and mixed-type JSON paths across rows.ByteSource, and safely falls back to raw bytes for unsupported types.JSONshared-data overflowCloses #599
Closes #615
Closes #674
Closes #466
Checklist
Delete items not relevant to your PR: