Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom HTTP headers at the connection level in ClickHouse.Driver. Custom headers enable proxy authentication, distributed tracing, and other scenarios requiring additional HTTP headers in requests.
Key changes:
- New
CustomHeadersproperty inClickHouseClientSettingsfor specifying custom headers - Security filtering to prevent overriding critical headers (Authorization, User-Agent, Connection)
- Comprehensive test coverage for custom header application and blocked header validation
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/Advanced_007_CustomHeaders.cs | New example demonstrating proxy authentication headers usage |
| examples/Program.cs | Integrated custom headers example into example runner |
| examples/README.md | Added documentation entry for custom headers example |
| ClickHouse.Driver/ADO/ClickHouseClientSettings.cs | Added CustomHeaders property with deep copy, equality, hash code, and string representation support |
| ClickHouse.Driver/ADO/ClickHouseConnection.cs | Implemented header application logic with security filtering via IsBlockedHeader |
| ClickHouse.Driver/PublicAPI/PublicAPI.Unshipped.txt | Tracked new public API surface for CustomHeaders property |
| ClickHouse.Driver.Tests/ADO/CustomHeadersTests.cs | Added comprehensive tests for header application and blocking behavior |
| ClickHouse.Driver.Tests/ADO/ClickHouseClientSettingsTests.cs | Extended settings tests to cover CustomHeaders property behavior |
| RELEASENOTES.md | Documented new custom headers feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.