Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on code cleanup, documentation improvements, and minor API refinements across the ClickHouse.Driver codebase.
Changes:
- Added comprehensive XML documentation to ADO.NET types (ClickHouseCommand, ClickHouseDbParameter, ClickHouseConnection)
- Converted
ClickHouseDecimal.MaxDivisionPrecisionfrom a field to a property for better API design - Improved diagnostics with culture-invariant formatting for BigInteger and ClickHouseDecimal in JSON serialization
- Added analyzer suppressions for intentional design decisions (certificate validation skip, CS0109 warnings)
- Code formatting improvements (multi-line statement formatting, constant extraction in logging)
- PublicAPI surface updates reflecting new members and feature flags
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ClickHouse.Driver/Utility/EnumerableExtensions.cs | Reformatted do-while statement |
| ClickHouse.Driver/Types/JsonType.cs | Added culture-invariant formatting for numerics, improved comment placement, refined return type |
| ClickHouse.Driver/Types/BinaryTypeDecoder.cs | Added pragma to suppress false-positive analyzer warning, refined return type |
| ClickHouse.Driver/Types/BFloat16Type.cs | Improved struct field formatting |
| ClickHouse.Driver/PublicAPI/*.txt | Updated public API surface tracking |
| ClickHouse.Driver/Numerics/ClickHouseDecimal.cs | Converted field to property, updated XML docs |
| ClickHouse.Driver/Logging/LoggingHelpers.cs | Extracted constant for message format |
| ClickHouse.Driver/IClickHouseConnection.cs | Added pragma to suppress CS0109 warning |
| ClickHouse.Driver/Http/HttpHandlerProvider.cs | Added security analyzer suppression with justification |
| ClickHouse.Driver/Http/HttpClientHelpers.cs | Added performance analyzer suppression |
| ClickHouse.Driver/Diagnostic/TraceHelper.cs | Improved log message formatting |
| ClickHouse.Driver/DependencyInjection/ClickHouseServiceCollectionExtensions.cs | Improved method call formatting |
| ClickHouse.Driver/ClickHouseServerException.cs | Added .NET 6+ optimization using Span |
| ClickHouse.Driver/ClickHouse.Driver.csproj | Removed duplicate AdditionalFiles entry |
| ClickHouse.Driver/ADO/Parameters/ClickHouseDbParameter.cs | Added comprehensive XML documentation |
| ClickHouse.Driver/ADO/Feature.cs | Enhanced obsolete attribute message |
| ClickHouse.Driver/ADO/ClickHouseConnectionStringBuilder.cs | Added analyzer suppression, formatting fix |
| ClickHouse.Driver/ADO/ClickHouseConnection.cs | Property formatting, pragma suppressions |
| ClickHouse.Driver/ADO/ClickHouseCommand.cs | Added comprehensive XML documentation |
| ClickHouse.Driver/ADO/ClickHouseClientSettings.cs | Removed redundant initializer, improved HashCode usage |
| .editorconfig, ClickHouse.Driver/.editorconfig | Updated analyzer severity settings |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly formatting stuff.
Note
Adds and refines ADO APIs and diagnostics
InsertRawStreamAsyncfor direct streaming inserts;PostStreamAsyncoverloads now returnHttpResponseMessageand accept optionalqueryIdClickHouseCommand.BearerToken; command now exposesServerTimezoneand enhanced query stats handlingClickHouseClientSettings:Databasenow settable;EnableDebugModeintegrates withTraceHelper(NET5+) for low-level network tracing; validation tightenedTraceHelperclass; richer HttpClient/handler config logging; small parsing perf tweak inClickHouseServerExceptionMisc and quality
.editorconfigadds PublicAPI analyzer severities; csproj cleanupWritten by Cursor Bugbot for commit c1d63ae. This will update automatically on new commits. Configure here.