Make DI example clearer wrt connection and httpclient lifetime handling#195
Merged
alex-clickhouse merged 3 commits intomainfrom Jan 28, 2026
Merged
Make DI example clearer wrt connection and httpclient lifetime handling#195alex-clickhouse merged 3 commits intomainfrom
alex-clickhouse merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mzitnik
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Enhances the DI example to correctly demonstrate client/connection lifetimes and shared HttpClient/handler usage.
HttpClient, singletonClickHouseConnection, or using singletonClickHouseDataSourceIHttpClientFactoryintegration by registeringAddClickHouseDataSourcevia a settings factory, ensuring a sharedSocketsHttpHandlerexamples/README.mddescription to note proper lifetime handlingWritten by Cursor Bugbot for commit e485ec3. This will update automatically on new commits. Configure here.