Merged
Conversation
mzitnik
approved these changes
Apr 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release documentation to reflect the correct set of features and improvements for v1.2.0 by reorganizing entries between versions.
Changes:
- Add v1.2.0 entries for POCO binary inserts and configurable parameter type resolution.
- Introduce an Improvements section for v1.2.0 (including the
IPAddress.AddressFamilyinference change). - Remove the standalone v1.1.1 section and consolidate its content into v1.2.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RELEASENOTES.md | Reorganizes v1.2.0 content, adds improvements section, removes v1.1.1 entry. |
| CHANGELOG.md | Mirrors the same v1.2.0 restructuring and v1.1.1 removal for changelog consistency. |
| * Centralized parameter type resolution into `ParameterTypeResolution`, replacing previously scattered logic in `ClickHouseDbParameter.QueryForm` and `HttpParameterFormatter`. Each parameter's type is now resolved exactly once per request, ensuring consistency between SQL placeholder generation and HTTP value formatting. | ||
|
|
||
| **Bug Fixes:** | ||
| * `JsonReadMode` and `JsonWriteMode` will now correcly set the corresponding settings when set to `Binary` mode. |
There was a problem hiding this comment.
Typo in release notes: "correcly" should be "correctly".
Suggested change
| * `JsonReadMode` and `JsonWriteMode` will now correcly set the corresponding settings when set to `Binary` mode. | |
| * `JsonReadMode` and `JsonWriteMode` will now correctly set the corresponding settings when set to `Binary` mode. |
| * Centralized parameter type resolution into `ParameterTypeResolution`, replacing previously scattered logic in `ClickHouseDbParameter.QueryForm` and `HttpParameterFormatter`. Each parameter's type is now resolved exactly once per request, ensuring consistency between SQL placeholder generation and HTTP value formatting. | ||
|
|
||
| **Bug Fixes:** | ||
| * `JsonReadMode` and `JsonWriteMode` will now correcly set the corresponding settings when set to `Binary` mode. |
There was a problem hiding this comment.
Typo in changelog: "correcly" should be "correctly".
Suggested change
| * `JsonReadMode` and `JsonWriteMode` will now correcly set the corresponding settings when set to `Binary` mode. | |
| * `JsonReadMode` and `JsonWriteMode` will now correctly set the corresponding settings when set to `Binary` mode. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.