-
Notifications
You must be signed in to change notification settings - Fork 405
Functions: start generating dictionary functions #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces infrastructure for autogenerating documentation for dictionary functions in ClickHouse.
Key changes:
- Adds "Dictionary" to the list of function categories to be processed
- Configures source and destination file mappings for dictionary function documentation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "Dates and Times" | ||
| "Dictionary" |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The 'Dictionary' entry is inserted between 'Dates and Times' and 'Encoding', breaking alphabetical ordering. Consider maintaining alphabetical order by placing it after 'Distance' or reorganizing the entire list alphabetically for better maintainability.
| "Dates and Times" | |
| "Dictionary" | |
| "Dictionary" | |
| "Dates and Times" |
| "conditional-functions.md" | ||
| "distance-functions.md" | ||
| "dates_and_times-functions.md" | ||
| "dictionary-functions.md" |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The source filename 'dictionary-functions.md' follows the pattern of other entries but is inserted between 'dates_and_times-functions.md' and 'encoding-functions.md'. For consistency and maintainability, consider ordering this list alphabetically or according to the same sequence used in the function categories list.
…into Blargian-patch-940827
Summary
Checklist