WIP Design #1581
Merged
WIP Design #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
reviewed
Apr 3, 2024
Contributor
mzitnik
left a comment
mzitnik
left a comment
There was a problem hiding this comment.
Please also specify annotations and POJO read example
|
|
||
| @Test | ||
| public void insertSimplePOJOs() throws ClickHouseException, SocketException { | ||
| ClickHouseSettings settings = new ClickHouseSettings.Builder() |
Contributor
There was a problem hiding this comment.
We can move with the same line InsertSettings
chernser
reviewed
Apr 3, 2024
client-v2/src/main/java/com/clickhouse/client/api/ClickHouseSettings.java
Outdated
Show resolved
Hide resolved
chernser
reviewed
Apr 3, 2024
client-v2/src/main/java/com/clickhouse/client/api/ClickHouseSettings.java
Outdated
Show resolved
Hide resolved
|
chernser
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: