Skip to content

Conversation

@Paultagoras
Copy link
Contributor

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras requested review from chernser and mzitnik June 20, 2024 14:51
@Paultagoras Paultagoras self-assigned this Jun 20, 2024
@Paultagoras Paultagoras requested a review from chernser June 24, 2024 00:03
@Paultagoras
Copy link
Contributor Author

@chernser So I changed things around a bit so that queryId is a more explicit method and just stored as a string - I'd like to avoid overcomplicating things if we can, since that led to weird places in V1

@chernser
Copy link
Contributor

@Paultagoras Thank you for the change!

@chernser chernser merged commit 1b0a40e into main Jun 25, 2024
@Paultagoras Paultagoras deleted the add-query-id-v2 branch June 25, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants