Skip to content

Conversation

@BentsiLeviav
Copy link
Contributor

Summary

To improve our metrics and tracking, we added two more frameworks that can use the JDBC package: Flink JDBC and NIFI JDBC.

This feature was verified for the Flink JDBC connector.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2025

@mshustov mshustov requested a review from Copilot May 5, 2025 14:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the JDBC driver frameworks detection to include Apache Flink and Apache NiFi, supporting enhanced metrics and tracking for these frameworks.

  • Updated the frameworks detection list in Driver.java to include "apache.flink" and "apache.nifi"
  • Updated the frameworks detection list in DriverV1.java similarly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
jdbc-v2/src/main/java/com/clickhouse/jdbc/Driver.java Updated frameworks detection list to include Apache Flink and Apache NiFi
clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/DriverV1.java Updated frameworks detection list to include Apache Flink and Apache NiFi
Comments suppressed due to low confidence (2)

jdbc-v2/src/main/java/com/clickhouse/jdbc/Driver.java:37

  • Ensure that the new frameworks (Apache Flink and Apache NiFi) are covered by unit tests to verify that the detection logic functions as intended.
private static final List<String> FRAMEWORKS_TO_DETECT = Arrays.asList("apache.spark", "apache.flink", "apache.nifi");

clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/DriverV1.java:50

  • Consider adding or updating tests for DriverV1 to include scenarios for Apache Flink and Apache NiFi detection.
private static final List<String> FRAMEWORKS_TO_DETECT = Arrays.asList("apache.spark", "apache.flink", "apache.nifi");

@BentsiLeviav BentsiLeviav merged commit 76dbe35 into main May 6, 2025
25 checks passed
@BentsiLeviav BentsiLeviav deleted the add-more-frameworks-detection branch May 6, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants