Skip to content

[client-v2] removed usage of ClickHouseNode from main code #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chernser merged 1 commit into from
May 28, 2025
Merged

[client-v2] removed usage of ClickHouseNode from main code #2385

chernser merged 1 commit into from
May 28, 2025

Conversation

@chernser
Copy link
Contributor

@chernser chernser commented May 22, 2025 •
edited
Loading

Summary

Removes usage of ClickHouseNode in main code.

Closes #2120

Checklist

Delete items not relevant to your PR:

  • Closes #
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from mzitnik May 22, 2025 18:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 22, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
79.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@chernser chernser merged commit 0210d91 into main May 28, 2025
24 of 25 checks passed
@chernser chernser deleted the v2_remove_clickhouse_node branch May 28, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzitnik mzitnik mzitnik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[client-v2] Remove usage of ClickHouseNode class

3 participants

@chernser @mzitnik