Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
clickhouse-r2dbc/src/test/java/com/clickhouse/r2dbc/spi/test/R2DBCTestKitImplTest.java
Show resolved
Hide resolved
clickhouse-client/src/test/java/com/clickhouse/client/ClientIntegrationTest.java
Show resolved
Hide resolved
kurnoolsaketh
approved these changes
Mar 13, 2026
kurnoolsaketh
left a comment
kurnoolsaketh
left a comment
There was a problem hiding this comment.
approving since these are test changes and i trust you have validated them, but i'm missing some context. Also, will you address the deprecation warnings?
clickhouse-client/src/test/java/com/clickhouse/client/ClickHouseTestClient.java
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2783
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Mostly test/CI changes, but it also tweaks R2DBC connection option parsing to accept
custom_http_params, which can affect runtime connection URLs and HTTP settings behavior.Overview
Stabilizes integration tests across client/JDBC/R2DBC by consistently disabling async inserts (via
async_insert=0/custom_http_params) in streaming inserts, transaction tests, proxy tests, and HTTP connection reuse tests.Updates R2DBC URL option handling to allow passing
custom_http_paramsthroughConnectionFactoryOptions, and fixes a JDBC v2 metadata assertion by mappingUInt128toTypes.NUMERIC(instead ofTypes.OTHER). Also narrowsClickHouseTestClient.accept()to only match the MySQL protocol to avoid unintended selection in other tests, and adjusts CI to install only JDK 21 using Corretto in the compile workflow.Written by Cursor Bugbot for commit ecdbcb0. This will update automatically on new commits. Configure here.