3.1 jdbc driver broke float handling for nan/inf #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
grantatspothero
force-pushed
the
grantnicholas/fixJdbcDriverFloatInfNaNHandling
branch
from
27c0324 to
3a1799c
Compare
grantatspothero
commented
Nov 30, 2021
| assertEquals(70511139L, rs.getLong(2)); | ||
| } | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
Nothing changed about this testcase, intellij just warned me it was missing a "@test" annotation.
grantatspothero
force-pushed
the
grantnicholas/fixJdbcDriverFloatInfNaNHandling
branch
2 times, most recently
from
e34f857 to
3ca5c06
Compare
Contributor
|
Thank you @grantatspothero for the contribution. We're working on 0.3.2 which is a complete rewrite and we'll move to a RowBinary-based new JDBC driver, which supports nan/inf(examples). Anyway, I changed target branch from |
ResultSet.getFloat and ResultSet.getObject(Float.class) did not agree with each other
grantatspothero
force-pushed
the
grantnicholas/fixJdbcDriverFloatInfNaNHandling
branch
from
3ca5c06 to
6cc8b68
Compare
|
|
Contributor
Author
|
@zhicwu Just a bump |
Contributor
Sorry for the late response. Will merge this pull request after I'm done with another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading from the jdbc driver from 2.x to 3.x I noticed this following error occurring in tests (for the trinodb project)
The root cause of the problem is
ResultSet.getFloatandResultSet.getObject(Float.class)use different parsing functions (a custom double parser for getFloat and Float::valueOf for getObject): https://github.com/ClickHouse/clickhouse-jdbc/blob/v0.3.1-patch/clickhouse-jdbc/src/main/java/ru/yandex/clickhouse/response/parser/ClickHouseValueParser.java#L43-L45Clickhouse sends
[+|-]?infover the wire (not[+|-]?Infinity) so if you useResultSet.getObject(Float.class)theFloat::valueOffunction errors out.The fix is just creating a custom float parser (much like the double parser) such that both float and double parsing perform the same logic.