Skip to content

Conversation

@looskie
Copy link
Contributor

@looskie looskie commented Nov 16, 2025

Summary

The option to swap out the JSON.parse and JSON.stringify functions for custom ones. Fixes #246

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials
    ^ waiting for first reviewal before writing these. (or please advise if not needed)

@looskie
Copy link
Contributor Author

looskie commented Nov 17, 2025

will fix the tests after work today! f50f926

@looskie looskie requested a review from slvrtrn November 18, 2025 16:17
@looskie
Copy link
Contributor Author

looskie commented Nov 18, 2025

@slvrtrn can i get a CI approval 🙏

@slvrtrn
Copy link
Contributor

slvrtrn commented Nov 18, 2025

Thanks for your contribution! Cloud tests failing are unrelated; we cannot execute them for community PRs.

@looskie
Copy link
Contributor Author

looskie commented Nov 18, 2025

Thanks for your contribution! Cloud tests failing are unrelated; we cannot execute them for community PRs.

awesome! i plan to be a lot more involved with clickhouse and its OSS initiatives whenever i can ❤️

please let me know if theres anything else i need to do to get this shipped 🚀

@slvrtrn slvrtrn merged commit 2f96232 into ClickHouse:main Nov 19, 2025
22 of 26 checks passed
@looskie looskie deleted the custom_json_handling branch November 19, 2025 15:26
@slvrtrn
Copy link
Contributor

slvrtrn commented Nov 20, 2025

Released in https://github.com/ClickHouse/clickhouse-js/releases/tag/1.14.0
Thanks again.

@looskie
Copy link
Contributor Author

looskie commented Nov 20, 2025

Released in https://github.com/ClickHouse/clickhouse-js/releases/tag/1.14.0 Thanks again.

no worries! thanks for the speedy reviewal process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow custom JSON parsers in the client configuration

2 participants