feat(infra): update to eslint v10#643
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates ESLint from v9 to v10 as a maintenance update for the project's development dependencies. The upgrade includes version bumps to ESLint and related packages, cleanup of transitive dependencies in the lock file, removal of version constraints that were preventing the v10 upgrade, and an improvement to error handling in the Node.js stream utility by adding error cause chaining for better debugging.
Changes:
- Update ESLint from v9.39.4 to v10.1.0 and
@eslint/jsfrom v9.39.4 to v10.0.1 - Enhance error handling in stream.ts by adding error cause chaining to preserve original error context
- Remove dependabot ignore rules for ESLint v10 versions
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated eslint and @eslint/js to v10 |
| package-lock.json | Updated all dependencies and removed transitive packages no longer needed in v10 |
| .github/dependabot.yml | Removed version constraints that were blocking ESLint v10 updates |
| packages/client-node/src/utils/stream.ts | Added error cause property when re-throwing RangeError to improve debugging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@vitest/coverage-v8": "^4.1.0", | ||
| "apache-arrow": "^21.0.0", | ||
| "eslint": "^9.39.4", | ||
| "eslint": "^10.2.0", | ||
| "eslint-config-prettier": "^10.1.8", |
There was a problem hiding this comment.
@copilot apply changes based on this feedback in a new PR
## Summary Applies review feedback from [#643 (discussion_r3213961603)](#643 (comment)): ESLint v10 requires Node `^20.19.0`, but the root `engines.node` still advertises `>=20`, allowing 20.0–20.18 where ESLint v10 may not run reliably. - Bump root `engines.node` from `>=20` to `>=20.19.0` in `package.json`. Other `package.json` files in the repo are unaffected — `examples/{node,web}` and `tests/clickhouse-test-runner` pin ESLint v9, and `tests/clickhouse-test-runner` already declares `>=20.19.0`. ## Checklist - [x] A human-readable description of the changes was provided to include in CHANGELOG Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com> Co-authored-by: Peter Leonov <peter.leonov@clickhouse.com>
Summary
Update eslint to v10
Checklist