Re-export ResponseHeaders from client-node and client-web#758
Merged
Conversation
Copilot created this pull request from a session on behalf of
peter-leonov-ch
May 22, 2026 20:37
View session
|
|
peter-leonov-ch
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes ResponseHeaders as part of the public type surface of @clickhouse/client (node) and @clickhouse/client-web, reducing the need for downstream users to import it from @clickhouse/client-common ahead of that package’s planned deprecation.
Changes:
- Re-exported
type ResponseHeadersfrom@clickhouse/client-commonin the node client entrypoint. - Re-exported
type ResponseHeadersfrom@clickhouse/client-commonin the web client entrypoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/client-node/src/index.ts | Adds ResponseHeaders to the explicit re-export allowlist from @clickhouse/client-common. |
| packages/client-web/src/index.ts | Adds ResponseHeaders to the explicit re-export allowlist from @clickhouse/client-common. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepping
@clickhouse/client-commonfor deprecation. Audited the typeshyperdxio/hyperdximports from it (BaseResultSet,ClickHouseSettings,DataFormat,ResponseHeaders,ResponseJSON,Row,ClickHouseClient) against the re-export allowlists in@clickhouse/clientand@clickhouse/client-web. All butResponseHeaderswere already exposed.type ResponseHeadersto the common re-export blocks inpackages/client-node/src/index.tsandpackages/client-web/src/index.ts.Checklist