Skip to content

Re-export ResponseHeaders from client-node and client-web#758

Merged
peter-leonov-ch merged 1 commit into
mainfrom
copilot/update-hyperdx-imports
May 22, 2026
Merged

Re-export ResponseHeaders from client-node and client-web#758
peter-leonov-ch merged 1 commit into
mainfrom
copilot/update-hyperdx-imports

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

Summary

Prepping @clickhouse/client-common for deprecation. Audited the types hyperdxio/hyperdx imports from it (BaseResultSet, ClickHouseSettings, DataFormat, ResponseHeaders, ResponseJSON, Row, ClickHouseClient) against the re-export allowlists in @clickhouse/client and @clickhouse/client-web. All but ResponseHeaders were already exposed.

  • Added type ResponseHeaders to the common re-export blocks in packages/client-node/src/index.ts and packages/client-web/src/index.ts.

Checklist

  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@peter-leonov-ch peter-leonov-ch marked this pull request as ready for review May 22, 2026 20:37
@peter-leonov-ch peter-leonov-ch requested a review from mshustov as a code owner May 22, 2026 20:37
Copilot AI review requested due to automatic review settings May 22, 2026 20:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes ResponseHeaders as part of the public type surface of @clickhouse/client (node) and @clickhouse/client-web, reducing the need for downstream users to import it from @clickhouse/client-common ahead of that package’s planned deprecation.

Changes:

  • Re-exported type ResponseHeaders from @clickhouse/client-common in the node client entrypoint.
  • Re-exported type ResponseHeaders from @clickhouse/client-common in the web client entrypoint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/client-node/src/index.ts Adds ResponseHeaders to the explicit re-export allowlist from @clickhouse/client-common.
packages/client-web/src/index.ts Adds ResponseHeaders to the explicit re-export allowlist from @clickhouse/client-common.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@peter-leonov-ch peter-leonov-ch merged commit d595462 into main May 22, 2026
113 of 114 checks passed
@peter-leonov-ch peter-leonov-ch deleted the copilot/update-hyperdx-imports branch May 22, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants