feat: correctly handle ipv4-only envs#185
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the operator’s generated ClickHouse (and Keeper) network listening configuration so clusters start cleanly in IPv4-only environments by default, avoiding failures from an IPv6-only listen_host: "::" binding.
Changes:
- Switch ClickHouse server default
listen_hostto include both::and0.0.0.0, and enablelisten_try. - Update ClickHouse Keeper generated config to emit multiple
listen_hostentries and enablelisten_try. - Remove now-unnecessary
extraConfig.listen_host: "0.0.0.0"overrides from EKS/GKE example manifests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/controller/keeper/templates.go | Generates Keeper YAML config with dual-stack listen_host and listen_try enabled. |
| internal/controller/clickhouse/templates/network.yaml.tmpl | Adjusts default ClickHouse server network config to dual-stack listen_host plus listen_try. |
| examples/gcp_gke_ssd.yaml | Removes redundant IPv4 listen_host override from the example. |
| examples/aws_eks_gp3.yaml | Removes redundant IPv4 listen_host override from the example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
listen_host: "::"do not work in ipv4 only envs and require extra config to run.listen_tryis acceptable as a liveness probe that checks that the port is being listened to.What
Change the default listen config to work in IPv4-only environments by default
Related Issues
Fixes #169