Skip to content

feat: correctly handle ipv4-only envs#185

Merged
GrigoryPervakov merged 1 commit into
mainfrom
auto-without-ipv6
May 12, 2026
Merged

feat: correctly handle ipv4-only envs#185
GrigoryPervakov merged 1 commit into
mainfrom
auto-without-ipv6

Conversation

@GrigoryPervakov
Copy link
Copy Markdown
Member

Why

listen_host: "::" do not work in ipv4 only envs and require extra config to run.
listen_try is acceptable as a liveness probe that checks that the port is being listened to.

What

Change the default listen config to work in IPv4-only environments by default

Related Issues

Fixes #169

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the operator’s generated ClickHouse (and Keeper) network listening configuration so clusters start cleanly in IPv4-only environments by default, avoiding failures from an IPv6-only listen_host: "::" binding.

Changes:

  • Switch ClickHouse server default listen_host to include both :: and 0.0.0.0, and enable listen_try.
  • Update ClickHouse Keeper generated config to emit multiple listen_host entries and enable listen_try.
  • Remove now-unnecessary extraConfig.listen_host: "0.0.0.0" overrides from EKS/GKE example manifests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
internal/controller/keeper/templates.go Generates Keeper YAML config with dual-stack listen_host and listen_try enabled.
internal/controller/clickhouse/templates/network.yaml.tmpl Adjusts default ClickHouse server network config to dual-stack listen_host plus listen_try.
examples/gcp_gke_ssd.yaml Removes redundant IPv4 listen_host override from the example.
examples/aws_eks_gp3.yaml Removes redundant IPv4 listen_host override from the example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GrigoryPervakov GrigoryPervakov marked this pull request as ready for review May 12, 2026 09:35
@GrigoryPervakov GrigoryPervakov merged commit 6c1993c into main May 12, 2026
22 checks passed
@GrigoryPervakov GrigoryPervakov deleted the auto-without-ipv6 branch May 12, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The operator could detect if IPv6 is available within the cluster instead of defaulting to IPv6

2 participants