Skip to content

Conversation

@xolra0d
Copy link
Contributor

@xolra0d xolra0d commented Aug 9, 2025

Summary

Fixes #248

Requested in #248 description was added on how Client::clone works, as well as 2 tests to prove this.

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided so that we can include it in CHANGELOG later

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2025

CLA assistant check
All committers have signed the CLA.

@mshustov mshustov requested a review from slvrtrn August 10, 2025 15:10
serprex
serprex previously approved these changes Aug 12, 2025
Copy link

@svix-jplatte svix-jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just wanted to make a PR for this myself :)

slvrtrn
slvrtrn previously approved these changes Aug 19, 2025
@xolra0d xolra0d dismissed stale reviews from slvrtrn and serprex via f53cba5 August 19, 2025 17:15
@svix-jplatte svix-jplatte mentioned this pull request Aug 19, 2025
@xolra0d xolra0d closed this Aug 25, 2025
@svix-jplatte
Copy link

@xolra0d why did you close this?

@xolra0d
Copy link
Contributor Author

xolra0d commented Sep 11, 2025

Hi, sorry for that. I saw your PR about clippy errors in my PR and comment about them already been commited:

Closing this cause I pushed the fix without noticing this (sorry!).

I thought you just copied docs and ran clippy. I opened another #284 with the same docs and 2
formatted tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client::with_* don't affect previous clones of the client - intended?

5 participants