Name cloud integration resources after their PR (or 'nightly')#146
Open
sdairs wants to merge 1 commit into
Open
Name cloud integration resources after their PR (or 'nightly')#146sdairs wants to merge 1 commit into
sdairs wants to merge 1 commit into
Conversation
Workflow now exports CLICKHOUSE_CLOUD_TEST_RUN_LABEL per event (pr-NNN / nightly / manual-RUNID). TestContext::from_env folds the label into run_id so existing service names and tags pick it up, making leaked resources attributable to their source PR or run. Closes #138 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLICKHOUSE_CLOUD_TEST_RUN_LABELper event:pr-NNNonpull_request,nightlyonschedule,manual-<run_id>onworkflow_dispatch.TestContext::from_envreads the new var and folds it intorun_id, so existing service names (clickhousectl-it-<run_id>,clickhousectl-it-pg-<run_id>) and therun_idtag value automatically become PR/nightly-prefixed.Closes #138.
Test plan
cargo build -p clickhouse-cloud-api --testscargo test -p clickhouse-cloud-api(all 86 unit tests + 5 spec coverage tests pass)clickhousectl-it-pr-<NNN>-<sha7>resources and arun_id=pr-<NNN>-<sha7>tag (verify in Cloud console once the workflow finishes)nightly-<sha7>🤖 Generated with Claude Code