Skip to content

Fix cloud service update tag patch serialization#40

Merged
sdairs merged 2 commits intocodex/skills-commandfrom
codex/issue-36-service-update-tags
Mar 15, 2026
Merged

Fix cloud service update tag patch serialization#40
sdairs merged 2 commits intocodex/skills-commandfrom
codex/issue-36-service-update-tags

Conversation

@sdairs
Copy link
Copy Markdown
Collaborator

@sdairs sdairs commented Mar 14, 2026

Summary:

  • serialize UpdateServiceRequest.tags as a single patch object instead of an array
  • update the service update request builder to emit the live API-compatible shape
  • tighten serialization tests to assert tags is an object and document the current spec/live mismatch

Testing:

  • cargo test test_update_service_request_full
  • cargo test build_update_service_request_supports_patch_fields

Notes:

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts UpdateServiceRequest tag patch serialization to match the live ClickHouse Cloud API, which rejects tags when sent as an array.

Changes:

  • Change UpdateServiceRequest.tags from Option<Vec<InstanceTagsPatch>> to Option<InstanceTagsPatch>.
  • Update the update-service request builder to emit a single patch object for tags.
  • Tighten serialization tests to assert tags is an object and document the schema vs live API mismatch.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/cloud/types.rs Updates the request model so tags serializes as a single patch object.
src/cloud/commands.rs Updates the request builder/parser and its test to match the new JSON shape.
src/cloud/types_test.rs Updates serialization assertions and documents the live API expectation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@sdairs sdairs merged commit 1b2dae1 into codex/skills-command Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants