Fix cloud service update tag patch serialization#40
Merged
sdairs merged 2 commits intocodex/skills-commandfrom Mar 15, 2026
Merged
Fix cloud service update tag patch serialization#40sdairs merged 2 commits intocodex/skills-commandfrom
sdairs merged 2 commits intocodex/skills-commandfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts UpdateServiceRequest tag patch serialization to match the live ClickHouse Cloud API, which rejects tags when sent as an array.
Changes:
- Change
UpdateServiceRequest.tagsfromOption<Vec<InstanceTagsPatch>>toOption<InstanceTagsPatch>. - Update the update-service request builder to emit a single patch object for
tags. - Tighten serialization tests to assert
tagsis an object and document the schema vs live API mismatch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/cloud/types.rs |
Updates the request model so tags serializes as a single patch object. |
src/cloud/commands.rs |
Updates the request builder/parser and its test to match the new JSON shape. |
src/cloud/types_test.rs |
Updates serialization assertions and documents the live API expectation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Testing:
Notes: