Skip to content

Fix portable termios initialization#51

Merged
sdairs merged 1 commit intomainfrom
codex/fix-termios-build
Mar 16, 2026
Merged

Fix portable termios initialization#51
sdairs merged 1 commit intomainfrom
codex/fix-termios-build

Conversation

@sdairs
Copy link
Copy Markdown
Collaborator

@sdairs sdairs commented Mar 16, 2026

Summary

  • replace the manual \ initializer with a zero-initialized value before calling \
  • avoid platform-specific struct field mismatches such as missing \ during builds

Verification

  • cargo build
  • cargo test

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves portability of terminal raw-mode setup by avoiding manual libc::termios field-by-field initialization, which can fail to compile on platforms where the struct layout differs.

Changes:

  • Replace manual libc::termios { ... } construction with a generic zero-initialized libc::termios prior to calling tcgetattr.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@sdairs sdairs temporarily deployed to cloud-integration March 16, 2026 20:43 — with GitHub Actions Inactive
@sdairs sdairs requested a review from iskakaushik March 16, 2026 20:53
@sdairs sdairs merged commit 699e085 into main Mar 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants