Use consistent versioned user-agent for all HTTP requests#79
Merged
Conversation
All outbound HTTP requests now use "clickhousectl/{version}" from a
single shared module instead of inconsistent hardcoded strings
("clickhousectl", "ch-cli") scattered across the codebase.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Apply cargo fmt formatting as well. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All callers now use crate::user_agent::user_agent() directly instead of going through a redundant wrapper function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
iskakaushik
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_agent()into a sharedsrc/user_agent.rsmodule that returnsclickhousectl/{version}version_manager/(download, resolve, list) to use the shared function instead of hardcoded stringslist.rswhich was using"ch-cli"instead of"clickhousectl"cloud/client.rs::user_agent()now delegates to the shared moduleTest plan
cargo buildpassescargo test— all 199 tests passcargo clippy— no new warnings🤖 Generated with Claude Code