optimize hdfs seek #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@alexey-milovidov @alesapin @kssenii This code is same as Java client, and we have tested in our env. which will reduce network flow when seeking offset is too long from current offset result a performance improvement. Please merge. Thanks. |
Contributor
|
@alexey-milovidov Do you want to merge this? |
alexey-milovidov
approved these changes
Apr 10, 2023
Member
|
Thank you! We missed this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After optimizing the hdfs seek method, if the target of the seek method exceeds a certain length, the blockReader's skip method will not be called again to prevent frequent calls to the readNextPacket method, thus improving the performance of the seek method.