Conversation
serprex
approved these changes
Oct 31, 2025
Member
serprex
left a comment
serprex
left a comment
There was a problem hiding this comment.
do we also want to fallback to localhost when !*host?
Collaborator
Author
|
Couldn't hurt, though I just tried |
Otherwise, calls to `clickhouse_raw_query()` with a connection string that omits the host name causes an error. Using "localhost" as the default to match the default specified in the `CREATE FUNCTION` default. Add an empty connection string argument to a call to `clickhouse_raw_query()` in `tests/sql/http.sql` to test it. Resolves #18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, calls to
clickhouse_raw_query()with a connection string that omits the host name causes an error. Using "localhost" as the default to match the default specified in theCREATE FUNCTIONdefault. Add an empty connection string argument to a call toclickhouse_raw_query()intests/sql/http.sqlto test it.Resolves #18.