Skip to content

Conversation

@bstrdsmkr
Copy link

Description

Added Github Action to build and publish REF container to Github Container Registry

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lewisjared
Copy link
Contributor

Many thanks. This builds correctly AFAIK, and I believe that build failure is due to you working in a fork??

We enforce trailing spaces in our files using pre-commit, which can be added by running pre-commit install if you have it installed.

Finally, we also use changelog files (see changelog/README.md)

@bstrdsmkr bstrdsmkr closed this Mar 12, 2025
@bstrdsmkr bstrdsmkr reopened this Mar 12, 2025
@bstrdsmkr bstrdsmkr force-pushed the docker-ci branch 2 times, most recently from a749e6b to edfcb93 Compare March 12, 2025 18:09
Copy link
Contributor

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I haven't tried pulling the container locally. Let me know if this is ready to go or if you wanted to add more to this PR

@bstrdsmkr
Copy link
Author

@lewisjared I think this is mostly good to go for a first pass, except I don't see the image showing up at https://github.com/orgs/Climate-REF/packages even though it appears to have pushed successfully. Could the package be marked as private?

@lewisjared lewisjared marked this pull request as ready for review March 17, 2025 13:40
@lewisjared lewisjared merged commit 2e68d86 into Climate-REF:main Mar 17, 2025
25 of 26 checks passed
@lewisjared
Copy link
Contributor

Yes it was private, but I've changed it to now be public

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants