Skip to content

Conversation

@lewisjared
Copy link
Contributor

@lewisjared lewisjared commented Apr 3, 2025

Description

Adds an integration test for PMP's extratropical modes of variability metric and adds the PMP metrics to the integration test suite.

The integration tests only run if the argument --slow is provided to pytest (either via PYTEST_ADDOPTS environment variable or the command line).

This actually runs the metric (unlike the unit test). @lee1043 This might be useful for your debugging

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...f-metrics-pmp/src/cmip_ref_metrics_pmp/__init__.py 100.00% <ø> (ø)
...metrics-pmp/src/cmip_ref_metrics_pmp/pmp_driver.py 87.50% <100.00%> (+0.40%) ⬆️
...-pmp/src/cmip_ref_metrics_pmp/variability_modes.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* origin/main:
  docs: changelog
  chore: Update lockfile
  chore: Add some additional pins to describe the minimum allowed dependencies
  docs: Add documentation for our support of spec0000
  chore: Remove support for python 3.10
* origin/main:
  docs: changelog
  test: Fix up tests
  fix: Ensure that the paths are always absolute
@lewisjared lewisjared requested a review from lee1043 April 5, 2025 17:29
Copy link
Contributor

@lee1043 lee1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for adding this!

@lewisjared lewisjared merged commit 09c9944 into main Apr 6, 2025
18 checks passed
@lewisjared lewisjared deleted the fix-pmp-variability branch April 6, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants