-
Notifications
You must be signed in to change notification settings - Fork 10
test: Add integration tests for pmp diagnostics #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
* origin/main: docs: changelog chore: Update lockfile chore: Add some additional pins to describe the minimum allowed dependencies docs: Add documentation for our support of spec0000 chore: Remove support for python 3.10
* origin/main: docs: changelog test: Fix up tests fix: Ensure that the paths are always absolute
lee1043
approved these changes
Apr 6, 2025
Contributor
lee1043
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an integration test for PMP's extratropical modes of variability metric and adds the PMP metrics to the integration test suite.
The integration tests only run if the argument
--slowis provided to pytest (either viaPYTEST_ADDOPTSenvironment variable or the command line).This actually runs the metric (unlike the unit test). @lee1043 This might be useful for your debugging
Checklist
Please confirm that this pull request has done the following:
changelog/